error out if any unsupported fortran logical operators are found

metrumresearchgroup · Aug 14, 2024 · 2531941 · 2531941
1 parent aa5c54b
commit 2531941
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/R/filter-nm-data.R b/R/filter-nm-data.R
@@ -82,6 +82,18 @@ get_data_filter_exprs <- function(.mod){
 #' @keywords internal
 #' @seealso [invert_operator()], [translate_nm_expr()]
 translate_nm_operator <- function(expr) {
+  # Check for unsupported operators
+  bad_ops <- c(".OR.",".AND", ".NOT.")
+  bad_ops_pat <- paste(bad_ops, collapse = "|")
+  if(any(grepl(bad_ops_pat, expr))){
+    cli::cli_abort(
+      c(
+        "The following logical operators are not supported {.var {bad_ops}}",
+        "i" = "See NONMEM documentation for more details"
+      )
+    )
+  }
+
   # Equal
   expr <- gsub(".EQ.", "==", expr, fixed = TRUE)
   expr <- gsub(".EQN.", "==", expr, fixed = TRUE)

diff --git a/tests/testthat/test-filter-nm-data.R b/tests/testthat/test-filter-nm-data.R
@@ -45,6 +45,13 @@ test_that("translate_nm_expr() translates NONMEM filter expressions", {
     translate_nm_expr("@", data_cols = data_cols),
     paste0("!grepl('^\\\\s*[A-Za-z@]', ", data_cols[1], ")")
   )
+
+  # Error out for unsupported logical operators
+  test_exprs_bad <- c(test_exprs, "GEN=1 .AND. AGE > 60")
+  expect_error(
+    translate_nm_expr(test_exprs_bad, type = 'accept'),
+    "The following logical operators are not supported"
+  )
 })
 
 test_that("filter_nm_data() filters input data using IGNORE/ACCEPT options", {