feat: return HTTPResponse from certain methods
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are `Document.save()`, `Document.delete()`, and `Document.copy()`. Breaking change: `Document.copy()` does not return a `Document` anymore. You can use the ETag and fetch the document yourself. Fixes #49
bmario
added
the
breaking
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 97.15% 97.19% +0.04%
==========================================
Files 13 13
Lines 950 964 +14
==========================================
+ Hits 923 937 +14
Misses 27 27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are
Document.save(),Document.delete(), andDocument.copy().Breaking change:
Document.copy()does not return aDocumentanymore. You can use the ETag and fetch the document yourself. Rationale: For efficiency, retrieving the copied document automatically is a bad idea anyways, so returning the response instead does not seem to be an issue. If you need the document, use the ETag, which is a part of the response object, to retrieve it.Closes #49