Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies for Go 1.18 #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kainoaseto
Copy link
Contributor

When using Go 1.18, building the binary with make resulted in this failure:

go generate github.com/metaverse/truss/gengokit/template
go install -ldflags '-X "main.version=fcd9ff140d" -X "main.date=2021-07-14T06:36:40Z"' github.com/metaverse/truss/cmd/truss
# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall_darwin.1_13.go:25:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
vendor/golang.org/x/sys/unix/zsyscall_darwin_amd64.go:121:3: too many errors
make: *** [truss] Error 2

I've done a few things in this PR:

  • update the reference to golang.org/x/sys with go get -u golang.org/x/sys
  • update the go.mod file to reference go 1.18
  • run go mod vendor with all the new dependency versions

@zaquestion
Copy link
Member

Couple comments at a glance. The vendored gogo dependency seems to have regressed. I see several areas where ProtoVersion2 is used instead of 3 and that constant has been removed entirely. That doesn't quite seem right.

Other than that, if we're going to bring these changes in we should also update the CI to run on go 1.17.x and 1.18.x (historically we've supported the 2 most recent versions)

@zaquestion
Copy link
Member

Appreciate the effort you're putting into updating this stuff! Curious to hear how you're using truss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants