Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump guava to a version which works with Java 11 #7

Open
johanrydstrom opened this issue Aug 15, 2019 · 1 comment · May be fixed by #8
Open

Bump guava to a version which works with Java 11 #7

johanrydstrom opened this issue Aug 15, 2019 · 1 comment · May be fixed by #8

Comments

@johanrydstrom
Copy link

I work for a client which depends on rdi-client-java to POST data to metamx. In their codebase they also depend on this to work
com.google.common.reflectClassPath.from(ClassLoader.getSystemClassLoader()).getAllClasses()
which stopped working with an upgrade to Java 11. It turns out that this doesn't work (returns an empty Set) in conjunction with older (than 24-something) Guava versions.

Current rdi-client-java (through it's transitive dependency on com.metamx:java-util) drags in com.google.guava:14.0.1. Due to a API-change in Guava (Futures.addCallback now takes 3 parameters, was 2) I can't bump the version in our library; it has to be fixed in rdi-client-java.

I might be able to create a PR, if needed?
@johanrydstrom
Copy link
Author

Also in even more modern versions of Guava Futures.transform() has changed it's signature for asynchronous use-cases and should be replaced by Futures.transformAsync().

johanrydstrom pushed a commit to videoplaza/rdi-client-java that referenced this issue Oct 23, 2019
Bump Guava to make reflections work with Java 11
e897a4f 
With Java 11 and Guava 14.0.x `com.google.common.reflectClassPath.from(ClassLoader.getSystemClassLoader()).getAllClasses()` returns an empty `Set`. From a consumers perspective it is not possible to upgrade Guava on that side since `rdi-client-java` depends on a version of Guava which has had a non-compatible API change.

Resolves: metamx#7
@johanrydstrom johanrydstrom linked a pull request Oct 23, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Guava to make reflections work with Java 11 videoplaza/rdi-client-java
1 participant
@johanrydstrom