Add more debug logs for task action

review comment review comments
metamx · Mar 9, 2016 · 6195e79 · 6195e79
1 parent 9e82ed8
commit 6195e79
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/indexing-service/src/main/java/io/druid/indexing/common/actions/LocalTaskActionClient.java b/indexing-service/src/main/java/io/druid/indexing/common/actions/LocalTaskActionClient.java
@@ -43,7 +43,7 @@ public LocalTaskActionClient(Task task, TaskStorage storage, TaskActionToolbox t
   public <RetType> RetType submit(TaskAction<RetType> taskAction) throws IOException
   {
     log.info("Performing action for task[%s]: %s", task.getId(), taskAction);
-
+    long startTime = System.currentTimeMillis();
     if (taskAction.isAudited()) {
       // Add audit log
       try {
@@ -59,6 +59,13 @@ public <RetType> RetType submit(TaskAction<RetType> taskAction) throws IOExcepti
       }
     }
 
-    return taskAction.perform(task, toolbox);
+    RetType rv = taskAction.perform(task, toolbox);
+    log.debug(
+        "Completed action for task[%s]: %s. Took [%d]ms",
+        task.getId(),
+        taskAction,
+        System.currentTimeMillis() - startTime
+    );
+    return rv;
   }
 }
diff --git a/indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java b/indexing-service/src/main/java/io/druid/indexing/overlord/http/OverlordResource.java
@@ -238,6 +238,8 @@ public Response getWorkerConfigHistory(
   @Produces(MediaType.APPLICATION_JSON)
   public <T> Response doAction(final TaskActionHolder<T> holder)
   {
+    log.debug("Received action for task[%s]: %s", holder.getTask(), holder.getAction());
+
     return asLeaderWith(
         taskMaster.getTaskActionClient(holder.getTask()),
         new Function<TaskActionClient, Response>()
@@ -256,8 +258,8 @@ public Response apply(TaskActionClient taskActionClient)
               retMap = Maps.newHashMap();
               retMap.put("result", ret);
             }
-            catch (IOException e) {
-              log.warn(e, "Failed to perform task action");
+            catch (Exception e) {
+              log.warn(e, "Failed to perform action for task[%s]: %s", holder.getTask(), holder.getAction());
               return Response.serverError().build();
             }