Add mulGrp to iset.mm #4509
Merged
Add mulGrp to iset.mm #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avekens
reviewed
Dec 29, 2024
avekens
reviewed
Dec 29, 2024
Also, revise df-cnfld entry to refer to those items and to slightly expand the mention of order.
This is the syntax and df-mgp . It is copied from set.mm with the only change being to remove from the comment a few references to theorems iset.mm doesn't have and won't have for a while.
Stated as in set.mm. The proof needs some intuitionizing but is based on the set.mm proof.
This is mgpval from set.mm with an additional set existence condition. The proof needs some intuitionizing but is similar to the set.mm proof.
This is mgpplusg from set.mm with an additional set existence condition. The proof needs some intuitionizing but is basically the set.mm proof.
This is mgpbas from set.mm. The proof is based on the set.mm proof but needs intuitionizing.
This is scandxnbasendx , scandxnplusgndx , and scandxnmulrndx . Copied from set.mm. The only change is to remove comments which refer to theorems not present in iset.mm. Update iset-discouraged file.
This is mgpsca from set.mm with a set existence condition added. The proof is similar to the set.mm proof with some intuitionizing.
These are tsetndxnn , basendxlttsetndx , tsetndxnbasendx , tsetndxnplusgndx , tsetndxnmulrndx , tsetndxnstarvndx , and slotstnscsi . They are copied from set.mm with the only change being to remove comments referring to theorems not present in iset.mm. Update iset-discouraged file.
This is mgptset from set.mm with an additional set existence condition. The proof needs intuitionizing but is generally similar to the set.mm proof.
This is mgptopn from set.mm with an additional set existence condition. The proof needs intuitionizing but is similar to the set.mm proof.
This is dsndxnn , basendxltdsndx , dsndxnbasendx , dsndxnplusgndx , dsndxnmulrndx , slotsdnscsi , dsndxntsetndx , and slotsdifdsndx . Copied from set.mm with the only change being to remove references in the comments to theorems (most of them not in iset.mm). Update the iset-discouraged file.
This is mgpds from set.mm with an addition set existence condition. The proof is similar to the set.mm proof.
This is the syntax and df-ur . Copied without change from set.mm.
This is ringidval from set.mm with an additional set existence condition. The proof is taken from a portion of the set.mm proof.
This is dfur2 from set.mm with an additional set existence condition. The proof needs some intuitionizing but is based on the set.mm proof.
This wording is based on github discussion and is intended to describe accurately and clearly how this definition works.
icecream17
approved these changes
Dec 30, 2024
avekens
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intuitionize the sections "Multiplicative Group" and "Ring unit".
There are a lot of changes around set existence but generally the intuitionizing is fairly smooth.