-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial 2sq development in iset.mm #4388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avekens
approved these changes
Nov 12, 2024
icecream17
approved these changes
Nov 13, 2024
Stated as in set.mm. The proof is similar to the set.mm proof but needs some intuitionizing.
Stated as in set.mm. The proof needs a small amount of intuitionizing but is only slightly changed from the set.mm proof.
Stated as in set.mm. The proof needs a small amount of intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a small amount of intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs some intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a little bit of intuitionizing but is basically the set.mm proof.
Stated as in set.mm. The proof needs a little bit of intuitionizing but is basically the set.mm proof.
Add 2sqlem11 and 2sq to mmil.html Don't refer to 2sq in comments because we haven't proved it yet.
The force-push just now was to rebase and resolve merge conflicts. I think I'll merge this once tests pass to avoid further merge conflicts including perhaps with #4391 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lemmas for
2sq
intuitionize with few or no changes until we get to2sqlem11
which depends on things we don't have yet. Although #4387 if merged would partially close that gap, it doesn't havelgsqr
andm1lgs
which are used by the2sqlem11
proof.Given that, it seems better to merge what I have now rather than keep it sitting on a long-lived branch where no one else can easily see it.