Handle update to goreleaser v2 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we were stating `version: latest` in the github-actions yaml this update snuck up on us. I decided to go ahead with the update instead of pinning to v1 since at some point we'll have to update anyway, might as well do it now. Use --clean not --rm-dist in goreleaser release step, removed in v1.15.0, see https://goreleaser.com/deprecations/#-rm-dist. Add `version: 2` to the .goreleaser.yml file since `goreleaser check` complained about it.
The default is now '~> v2'[1] which should be good. 1: https://github.com/goreleaser/goreleaser-action/blob/v6.0.0/README.md#inputs
DoctorVin
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously stating
version: latestin the goreleaser-action step and thus were bumped to v2 of goreleaser itself. v2 dropped--rm-dist, now named--clean. I opted to handle the update now while its nice and easy instead of later when it would likely be more of a pain.