-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inband firmware install #182
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
fea8a7c
device/interface: split DeviceQueryor into interfaces for inband and …
joelrebel 9f75e14
model/action: adds a few additional fields
joelrebel 4e70140
model/firmware: turn InbandInstall, Oem attributes to be boolean
joelrebel 2c1c8cc
app: load inband run mode configuration
joelrebel 1b1100b
download: move download into its own package so its available for reuse
joelrebel ffdb421
inband: Add actions and firmware install action handlers
joelrebel 3fb7ccd
runner: implement support to resume Actions and Steps
joelrebel 4df09c4
worker/task_handler: implement support for both inband and outofband …
joelrebel 4b6baa2
cmd: update cli to run inband and outofband installs
joelrebel eddcd6a
go: pin to ctrl, rivets with required changes
joelrebel a789d1e
oob/helpers: fixes incorrect BMC user parameter
joelrebel adfe3b1
download: increment timeout for slow connections
joelrebel 6236eb6
go mod tidy
joelrebel 237d2e1
store/fleetdb: copy inbandInstall, Oem bool values from firmware set …
joelrebel 41f987a
inband: powercycle in the final component fw install action
joelrebel bf6442a
go: pin ctrl, ironlib deps
joelrebel 27c22dc
go: update ironlib pin
joelrebel 4a72d80
inband/action_handlers: set powercycle required bool
joelrebel d5ef06d
inband/action: fail if no update utility was identified
joelrebel 1237287
go: pin to rivets, ctrl release
joelrebel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simplified: cf. https://pkg.go.dev/github.com/spf13/cobra#Command.MarkFlagsMutuallyExclusive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you a specific approach in mind here - since I do have the flags marked as mutually exclusive - https://github.com/metal-toolbox/flasher/pull/182/files/4a72d802c7d4c6603480f23a30eab371e82eea62#diff-8146f8148ccbf6711d65f532f6ab9a7c8dfbdc3960c7ffc974f17d6d224dd349R195-R196