Switch to rivets.{Server,Task} types and the TaskHandler interface #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelrebel
changed the title
jakeschuurmans
previously approved these changes
Aug 9, 2024
As a prerequisite to using the rivets.Task type
since we're transitioning to use the rivets.Task type
This is based on the changes in the previous commit
The rivets.Task type is to be used by all controllers to execute work recieved as conditions
This prepares the way to add inband fimware update support
The ctrl.NatsController deals with the Condition and passes a Task object to the controller handler. This way the controller itself does not have to deal with the Condition type and works with the Task type.
|
rebased on main |
jakeschuurmans
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Component,Assettypes and switches to the rivets equivalents.ctrlTaskHandlerandPublisherinterfaces.This mainly sets the stage for inband work along with enabling Task persistence.