FS-1833 #41
Merged
FS-1833 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert retry logic Install glibc in its entirety. Upkeep: -Update go-mod -Update gitrunner release go version
Fix bad condition error state
DoctorVin
approved these changes
Nov 11, 2024
| @@ -3,7 +3,7 @@ module github.com/metal-toolbox/bioscfg | |||
| go 1.23.1 | |||
|
|
|||
| require ( | |||
| github.com/bmc-toolbox/bmclib/v2 v2.3.4 | |||
| github.com/bmc-toolbox/bmclib/v2 v2.3.5-0.20241111155613-31918a066b74 | |||
There was a problem hiding this comment.
why not cut a release of bmclib?
There was a problem hiding this comment.
I just dont want to deal with the same stuff as last time. I made sure to pull this commit from main, instead of the branch, so this wont result in issues with the commit no longer existing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Update bmclib tag to incorporate SetBiosFromFile bug fix.
Fix bmc code so it uses sum when possible.
Fix condition error state not being set when connection to bmc client fails