WIP: Data entry mask #151
Open
WIP: Data entry mask #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjmolina
requested changes
Oct 13, 2021
| @@ -1,47 +1,67 @@ | |||
| <div *ngIf="currency && currency === 'USD'" class="prefix symbol"> | |||
| <span>$</span> | |||
| </div> | |||
| <input | |||
| #input | |||
| <div | |||
There was a problem hiding this comment.
¿para que hace falta un DIV? ¿para el ngIf? si es solo para eso, no es necerio, pon el if en el input y el text-area
un ng-content tambien hace lo mismo, sin añadir un elemento al DOM innecesario.
There was a problem hiding this comment.
añadir o quitar elementos de DOM a controles ya publicados tiene el efecto colateral de que puede romper selectores css
| readonly="true" | ||
| /> | ||
| </div> | ||
| <div |
| @@ -7,6 +7,22 @@ import { Injectable } from '@angular/core'; | |||
| export class RegexpService { | |||
There was a problem hiding this comment.
- Suggestion tiene la complejidad suficiente, para justificar que le implementemos test al 100%. Añadelos por favor.
- No necesitamos un servicio Angular, en el sentido que nadie va a inyectarlo y reemplazarlo desde el exterior.
Para simplicarlo, lo reconvertiria en clase (no servicio angular) probablemente con funcionalidad estatica (por ver).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122