Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Indices Mappings #1067

Merged
merged 7 commits into from
Dec 20, 2022

Conversation

bodo-hugo-barwich
Copy link
Contributor

@bodo-hugo-barwich bodo-hugo-barwich commented Aug 30, 2022

This implements the deep comparison of the deployed mappings in the ElasticSearch cluster and the definitions in the project.

$ bin/metacpan mapping --verify              # compare deployed indices and aliases with project definitions

This will show automatic unexpected adjustments made by the ElasticSearch engine which do not correspond to the intended structure.

This feature was requested and defined at:
Fix Index Corruption
as a result of the blocking incident documented at:
MetaCPAN API - Indexing failed

It introduces some of the same functionality like:
Clear Unknown Indices
which is required to create meaningful tests.

Copy link
Contributor

@mickeyn mickeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

lib/MetaCPAN/Script/Mapping.pm Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Outdated Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Outdated Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Outdated Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Outdated Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Show resolved Hide resolved
lib/MetaCPAN/Script/Mapping.pm Show resolved Hide resolved
@bodo-hugo-barwich
Copy link
Contributor Author

@mickeyn I critically reviewed the code and changed it where it was beneficial to maintainability or operational coherence.

@bodo-hugo-barwich
Copy link
Contributor Author

are you still interested in this feature ?

@oalders
Copy link
Member

oalders commented Dec 20, 2022

@mickeyn would you be able to take another look at this?

@mickeyn
Copy link
Contributor

mickeyn commented Dec 20, 2022

@oalders yes

Copy link
Contributor

@mickeyn mickeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickeyn mickeyn merged commit 3fe5278 into metacpan:master Dec 20, 2022
@oalders
Copy link
Member

oalders commented Dec 20, 2022

Thanks @bodo-hugo-barwich and @mickeyn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants