Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEARCH-690 (writer): Add artist credit MBID to output #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Dec 3, 2022

Problem: SEARCH-690 (writer part)

Search server doesn’t include MBID in results for search indexes (recording, release, release-group) that have artist credit.

Solution

  • Switch mmd-schema used to write the results to an (upcoming) version that includes artist credit MBID;
  • Add id attribute to artist-credit XML element.
  • Update XML and JSON tests accordingly

Todolist for author

Action after merge

  1. Release and deploy
  2. After rebuilding indexes with SEARCH-690 (indexer): Add artist credit MBID in indexes sir#157,
    make the updated WikiDocs page visible on MusicBrainz website

@yvanzo yvanzo marked this pull request as ready for review December 5, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant