-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added exporting playlists to Apple functionality #2968
base: master
Are you sure you want to change the base?
Conversation
Hello @rimma-kubanova! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-22 08:23:09 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whose review you were waiting for, but I think it's been long enough of a wait for me to jump in :)
Please excuse if I am unaware of some aspects of your project and some of the suggestions below are incorrect.
Overall looks good, some details need to be addressed before I can properly test the feature.
elif service == "soundcloud": | ||
apple_service = AppleService() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look right. Should it be this?
elif service == "soundcloud": | |
apple_service = AppleService() | |
elif service == "apple_music": | |
apple_service = AppleService() |
@MonkeyDo Hi! Thanks for your review! |
Export to Apple Music
Frontend:
APIService
Backend:
export_to_apple_music
toexport_playlist
endpoint.export_to_apple_music
calls troi