-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage and Footer Upgrade #739
base: master
Are you sure you want to change the base?
Homepage and Footer Upgrade #739
Conversation
akshaaatt
commented
Dec 7, 2021
•
edited
Loading
edited
- Removed Bookshelf.jpg and replaced it with MeB gradient style.
- Footer upgraded as per the other MeB projects.
- Removed Bookshelf.jpg and replaced it with MeB gradient style. - Footer upgraded as per the other MeB projects.
- Removed Bookshelf.jpg and replaced it with MeB gradient style. - Footer upgraded as per the other MeB projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting on that, and sorry I'm only looking at it now 😅
I still love the footer. However it looks like all the images are missing:
Regarding the gradient, we have a dark overlay over that section that changes what I think is the original intent.
Without the dark overlay this is what it looks like:
Makes it pretty hard to read.
I have a suggestion that keeps the background image we previously had but overlay the gradient with a multiply blend mode, something like that, what do you think?
I still think there should be a dark shadow under the "BookBrainz" text to make it more readable.
I must have left something out here maybe! Will fix this. Thanks for checking! |
…into akshat/homepage_and_footer � Conflicts: � src/client/components/footer.js
i would love to make changes @MonkeyDo |