Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage and Footer Upgrade #739

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

akshaaatt
Copy link
Member

@akshaaatt akshaaatt commented Dec 7, 2021

  • Removed Bookshelf.jpg and replaced it with MeB gradient style.
  • Footer upgraded as per the other MeB projects.

Screenshot from 2022-03-02 16-33-48

akshaaatt and others added 3 commits December 8, 2021 04:12
- Removed Bookshelf.jpg and replaced it with MeB gradient style.
- Footer upgraded as per the other MeB projects.
- Removed Bookshelf.jpg and replaced it with MeB gradient style.
- Footer upgraded as per the other MeB projects.
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on that, and sorry I'm only looking at it now 😅

I still love the footer. However it looks like all the images are missing:
image

Regarding the gradient, we have a dark overlay over that section that changes what I think is the original intent.
Without the dark overlay this is what it looks like:
image
Makes it pretty hard to read.

I have a suggestion that keeps the background image we previously had but overlay the gradient with a multiply blend mode, something like that, what do you think?
I still think there should be a dark shadow under the "BookBrainz" text to make it more readable.
image

@akshaaatt
Copy link
Member Author

I must have left something out here maybe! Will fix this. Thanks for checking!

@akshaaatt akshaaatt requested a review from MonkeyDo March 2, 2022 06:03
@akshaaatt
Copy link
Member Author

Regarding the gradient, we have a dark overlay over that section that changes what I think is the original intent. Without the dark overlay this is what it looks like: image Makes it pretty hard to read.

Agreed. In the latest commit, I improved the gradient situation. Let me know if that works fine for you. I believe we should get rid of an image background since the planned MusicBrainz revamp also follows the same.

@0PrashantYadav0
Copy link

i would love to make changes @MonkeyDo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants