Skip to content

Commit

Permalink
Update README to reflect fixed behavior for destroy-connection-pool!
Browse files Browse the repository at this point in the history
  • Loading branch information
camsaul committed Jul 8, 2019
1 parent 8ac66b3 commit 7ded45d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ You can set connection pool options such as size in a `c3p0.properties` file, or
"minPoolSize" 1
"initialPoolSize" 1
"maxPoolSize" 15})
(def my-pool-spec

(def my-pool-spec
(connection-pool/connection-pool-spec my-jdbc-spec connection-pool-properties))
```

Expand All @@ -44,11 +44,9 @@ See [https://www.mchange.com/projects/c3p0/#configuration_properties](https://ww
`destroy-connection-pool!` will destroy the connection pool you created:

```clj
(connection-pool/destroy-connection-pool! (:datasource pool-spec))
(connection-pool/destroy-connection-pool! pool-spec)
```

Note that due to me making bad decisions that I haven't fixed yet you currently have to pull the DataSource out of the pool spec yourself. (I plan to fix this in the future)

### Legal Stuff

Copyright © 2019 [Metabase, Inc](https://metabase.com/). This project is licensed under the Eclipse Public License, same as Clojure.
Copyright © 2019 [Metabase, Inc](https://metabase.com/). This project is licensed under the Eclipse Public License, same as Clojure.
2 changes: 1 addition & 1 deletion project.clj
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(defproject metabase/connection-pool "1.0.1"
(defproject metabase/connection-pool "1.0.2-SNAPSHOT"
:description "Connection pools for JDBC databases. Simple wrapper around C3P0."
:url "https://github.com/metabase/connection-pool"
:min-lein-version "2.5.0"
Expand Down

0 comments on commit 7ded45d

Please sign in to comment.