Fix linter

metabase · Oct 8, 2019 · 45dee74 · 45dee74
1 parent b3fd822
commit 45dee74
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/project.clj b/project.clj
@@ -49,7 +49,8 @@
 
    :bikeshed
    {:plugins
-    [[lein-bikeshed "0.5.2"]]}
+    [[lein-bikeshed "0.5.2"
+      :exclusions [org.clojure/tools.namespace]]]}
 
    :check-namespace-decls
    {:plugins               [[lein-check-namespace-decls "1.0.2"]]

diff --git a/test/metabase/connection_pool_test.clj b/test/metabase/connection_pool_test.clj
@@ -6,9 +6,14 @@
   {:classname "org.h2.Driver", :subprotocol "h2", :subname "mem:db"})
 
 (t/deftest properties-test
-  (t/is (= "acquireIncrement -> 1"
-           (->> (connection-pool/connection-pool-spec spec {"acquireIncrement" 1})
-                :datasource
-                str
-                (re-find #"acquireIncrement -> \d")))
-        "Options passed in to `connection-pool-spec` should get parsed correctly"))
+  (t/testing "Options passed in to `connection-pool-spec` should get parsed correctly"
+    (let [description (-> (connection-pool/connection-pool-spec spec {"acquireIncrement"        1
+                                                                      "testConnectionOnCheckin" true})
+                          :datasource
+                          str)]
+      (t/is (= "acquireIncrement -> 1"
+               (re-find #"acquireIncrement -> \d" description))
+            "numeric options should get converted correctly")
+      (t/is (= "testConnectionOnCheckin -> true"
+               (re-find #"testConnectionOnCheckin -> \w+" description))
+            "boolean options should get converted correctly"))))