fix: force redownload of Kubelet and kubectl binaries for Flatcar #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, upgraded Nodes ended up not actually upgrade the Kubelet version
|
Tested manually by using a dev image to run a pre-provisioned Kubernetes cluster upgrade (note the |
faiq
approved these changes
Aug 31, 2023
supershal
reviewed
Aug 31, 2023
| @@ -57,6 +57,7 @@ | |||
| mode: 0755 | |||
| owner: root | |||
| group: root | |||
| force: true | |||
There was a problem hiding this comment.
very interesting catch for preprovisioned case. I think we have to scan the KIB code to make sure we fix similar issues with other binaries.
There was a problem hiding this comment.
Yep I looked at that, this PR was actually a followup to https://d2iq.atlassian.net/browse/D2IQ-95908, we just missed it the first time :(
faiq
pushed a commit
that referenced
this pull request
Sep 7, 2023
Without this fix, upgraded Nodes ended up not actually upgrade the Kubelet version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Force redownload the Kubelet and kubectl binaries for Flatcar.
Without this fix, upgraded Nodes ended up not actually upgrading the Kubelet version.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: