Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows specific regional location image to be created for GCP #1184

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

manoj-nutanix
Copy link
Contributor

@manoj-nutanix manoj-nutanix commented Sep 24, 2024

What problem does this PR solve?:

Which issue(s) does this PR fix?:

Special notes for your reviewer:

konvoy-image-builder git:(NCN-102718) ✗ ./bin/konvoy-image-wrapper  build gcp --project-id ${GCP_PROJECT} --network ${NETWORK_NAME} images/gcp/ubuntu-2004.yaml --image-storage-locations us-west1
...
...
...
==> googlecompute.kib_image: Goss validate ran successfully
==> googlecompute.kib_image: 
==> googlecompute.kib_image: 
==> googlecompute.kib_image: 
==> googlecompute.kib_image: Downloading spec file and debug info
    googlecompute.kib_image: Downloading Goss specs from, /tmp/goss-spec.yaml and /tmp/debug-goss-spec.yaml to current dir
==> googlecompute.kib_image: Provisioning with shell script: /tmp/packer-shell1348402042
==> googlecompute.kib_image: Deleting instance...
    googlecompute.kib_image: Instance has been deleted!
==> googlecompute.kib_image: Creating image...
==> googlecompute.kib_image: Deleting disk...
    googlecompute.kib_image: Disk has been deleted!
==> googlecompute.kib_image: Running post-processor:  (type manifest)
Build 'googlecompute.kib_image' finished after 22 minutes 41 seconds.

==> Wait completed after 22 minutes 41 seconds

==> Builds finished. The artifacts of successful builds are:
--> googlecompute.kib_image: A disk image was created in the 'eng-ksphere-sandbox' project: konvoy-ubuntu-2004-1-29-6-20240924065827
--> googlecompute.kib_image: A disk image was created in the 'eng-ksphere-sandbox' project: konvoy-ubuntu-2004-1-29-6-20240924065827
➜  konvoy-image-builder git:(NCN-102718) ✗ 
Screenshot 2024-09-24 at 12 54 14 PM

Does this PR introduce a user-facing change?:


@supershal supershal changed the title [WIP] bug: allows specific regional location image to be created for GCP feat: allows specific regional location image to be created for GCP Nov 8, 2024
@supershal supershal self-assigned this Nov 8, 2024
@supershal
Copy link
Collaborator

Fixed github actions to build GCP images with GCP network and specific GCP storage location

@supershal supershal marked this pull request as ready for review November 8, 2024 18:19
@supershal supershal requested review from fatz, faiq and dkoshkin November 8, 2024 18:20
@supershal supershal added the runs-gcp-tests runs gcp tests label Nov 8, 2024
@supershal supershal merged commit 10da743 into main Nov 8, 2024
18 checks passed
@supershal supershal deleted the NCN-102718 branch November 8, 2024 19:34
supershal added a commit that referenced this pull request Nov 8, 2024
…1184)

* bug: allows specific regional location image to be created for GCP

* fix: revert go releaser changes

* ci: update GHA secret for GCP credentials

* build: set image storage location for gcp

* ci: use GCP infra varaible fro GHA

---------

Co-authored-by: Shalin Patel <[email protected]>
supershal added a commit that referenced this pull request Nov 8, 2024
…1184)

* bug: allows specific regional location image to be created for GCP

* fix: revert go releaser changes

* ci: update GHA secret for GCP credentials

* build: set image storage location for gcp

* ci: use GCP infra varaible fro GHA

---------

Co-authored-by: Shalin Patel <[email protected]>
supershal added a commit that referenced this pull request Nov 14, 2024
…1184) (#1224)

* bug: allows specific regional location image to be created for GCP

* fix: revert go releaser changes

* ci: update GHA secret for GCP credentials

* build: set image storage location for gcp

* ci: use GCP infra varaible fro GHA

---------

Co-authored-by: Manoj Surudwad <[email protected]>
supershal added a commit that referenced this pull request Nov 14, 2024
…1184) (#1223)

* bug: allows specific regional location image to be created for GCP

* fix: revert go releaser changes

* ci: update GHA secret for GCP credentials

* build: set image storage location for gcp

* ci: use GCP infra varaible fro GHA

---------

Co-authored-by: Manoj Surudwad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants