-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows specific regional location image to be created for GCP #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supershal
changed the title
[WIP] bug: allows specific regional location image to be created for GCP
feat: allows specific regional location image to be created for GCP
Nov 8, 2024
Fixed github actions to build GCP images with GCP network and specific GCP storage location |
dkoshkin
approved these changes
Nov 8, 2024
supershal
added a commit
that referenced
this pull request
Nov 8, 2024
…1184) * bug: allows specific regional location image to be created for GCP * fix: revert go releaser changes * ci: update GHA secret for GCP credentials * build: set image storage location for gcp * ci: use GCP infra varaible fro GHA --------- Co-authored-by: Shalin Patel <[email protected]>
supershal
added a commit
that referenced
this pull request
Nov 8, 2024
…1184) * bug: allows specific regional location image to be created for GCP * fix: revert go releaser changes * ci: update GHA secret for GCP credentials * build: set image storage location for gcp * ci: use GCP infra varaible fro GHA --------- Co-authored-by: Shalin Patel <[email protected]>
This was referenced Nov 8, 2024
supershal
added a commit
that referenced
this pull request
Nov 14, 2024
…1184) (#1224) * bug: allows specific regional location image to be created for GCP * fix: revert go releaser changes * ci: update GHA secret for GCP credentials * build: set image storage location for gcp * ci: use GCP infra varaible fro GHA --------- Co-authored-by: Manoj Surudwad <[email protected]>
supershal
added a commit
that referenced
this pull request
Nov 14, 2024
…1184) (#1223) * bug: allows specific regional location image to be created for GCP * fix: revert go releaser changes * ci: update GHA secret for GCP credentials * build: set image storage location for gcp * ci: use GCP infra varaible fro GHA --------- Co-authored-by: Manoj Surudwad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: