-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cloud init problems with ubuntu #1150
Conversation
I dont think this is quite ready this somehow pulled in an even older version of cloud init. |
4a09d1f
to
41a8c34
Compare
looks like this is working fine - added some extra commits to make it pull a newer cloud init. |
41a8c34
to
d4015f3
Compare
for some reason i get v22.0 but that has datasource.py
i think this is happening because our base iso is old |
added 9b114a7 to remove cloud-init dropin that configures cloud-init to use custom vmware guest datasource. |
58cdf0e
to
fa99aa0
Compare
Created release template and running konvoy e2e tests. |
* fix: install guest info if cloud init version is > 23.1.2 * ci: adds basic ubuntu test * fix: adds handling for redhat system and cloud init * !fixup: higher parallel * fix: adds override for ubuntu tests * do not merge: build basic os for ubuntu * do not merge: ensure new cloud init for tests * fix: remove package pining * fix: remvove cloud-init dropin for custom vmware guest datasource * fix: magefile configuration to create vsphere infa override file --------- Co-authored-by: Shalin Patel <[email protected]>
* fix: cloud init problems with ubuntu (#1150) * fix: install guest info if cloud init version is > 23.1.2 * ci: adds basic ubuntu test * fix: adds handling for redhat system and cloud init * !fixup: higher parallel * fix: adds override for ubuntu tests * do not merge: build basic os for ubuntu * do not merge: ensure new cloud init for tests * fix: remove package pining * fix: remvove cloud-init dropin for custom vmware guest datasource * fix: magefile configuration to create vsphere infa override file --------- Co-authored-by: Shalin Patel <[email protected]> * ci: run rocky basic e2e tests --------- Co-authored-by: Faiq <[email protected]>
* fix: cloud init problems with ubuntu (#1150) * fix: install guest info if cloud init version is > 23.1.2 * ci: adds basic ubuntu test * fix: adds handling for redhat system and cloud init * !fixup: higher parallel * fix: adds override for ubuntu tests * do not merge: build basic os for ubuntu * do not merge: ensure new cloud init for tests * fix: remove package pining * fix: remvove cloud-init dropin for custom vmware guest datasource * fix: magefile configuration to create vsphere infa override file --------- Co-authored-by: Shalin Patel <[email protected]> * ci: run rocky basic e2e tests --------- Co-authored-by: Faiq <[email protected]> Signed-off-by: Daniel Lipovetsky <[email protected]>
* fix: cloud init problems with ubuntu (#1150) * fix: install guest info if cloud init version is > 23.1.2 * ci: adds basic ubuntu test * fix: adds handling for redhat system and cloud init * !fixup: higher parallel * fix: adds override for ubuntu tests * do not merge: build basic os for ubuntu * do not merge: ensure new cloud init for tests * fix: remove package pining * fix: remvove cloud-init dropin for custom vmware guest datasource * fix: magefile configuration to create vsphere infa override file --------- * ci: run rocky basic e2e tests --------- Signed-off-by: Daniel Lipovetsky <[email protected]> Co-authored-by: Faiq <[email protected]>
What problem does this PR solve?:
This pr attempts to solve:
https://jira.nutanix.com/browse/NCN-100790
https://jira.nutanix.com/browse/NCN-102002
by only using our copied datasource module on older versions of cloud-init. this aligns us a little closer to the upstream image-builder tasks
attempting to build these images but im unable to run kib locally with my credentials for vsphere
this is safe for the current version we are pinning in ubuntu -- 23.1.2 because it already contains DataSourceVmWare.py
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: