Skip to content

Commit

Permalink
fix: push the image and copy modified commands to pull
Browse files Browse the repository at this point in the history
  • Loading branch information
faiq committed Oct 16, 2023
1 parent 2bade7b commit 045b561
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/podman-aws-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
run: go install github.com/goreleaser/[email protected]

- name: Build snapshot
run: make build.snapshot
run: make kib-image-push-amd64

- name: Run E2E test for AWS centos 7.9 using podman
run: |-
Expand Down
10 changes: 8 additions & 2 deletions cmd/konvoy-image-wrapper/image/image_not_embedded.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package image

import (
"fmt"
"os/exec"
)

Expand All @@ -14,7 +15,12 @@ func LoadImage(containerEngine string) error {
if imageLoaded(containerEngine, image) {
return nil
}

//nolint:gosec // this is necessary
cmd := exec.Command(containerEngine, "pull", Tag())
return cmd.Run()
cmd := exec.Command(containerEngine, "pull", fmt.Sprintf("docker.io/%s", Tag()))
err := cmd.Run()
if err != nil {
return fmt.Errorf("failed to pull image %s using cmd %s with error %w", Tag(), cmd.Args, err)
}
return nil
}

0 comments on commit 045b561

Please sign in to comment.