Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove collie kit compile command and add opentofu support #296

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

JohannesRudolph
Copy link
Member

@JohannesRudolph JohannesRudolph commented Aug 27, 2024

  • feat: remove the collie kit compile command

We figured out this use case is better served by tools like pre-commit-terraform
https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#terraform_validate
which includes more robust handling of terraform's quirks. Given that
there are better solutions out there, we think it's best to remove this
feature from collie and focus our resources on unique features.

Additionally, using "terraform validate" is a bad fit for validating
kit modules as it has big problems with configuration_aliases
hashicorp/terraform#28490
It seems that it is much better suited to validating platform modules instead.

  • feat: make collie info detect opentofu or terraform

We figured out this use case is better served by tools like pre-commit-terraform
https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#terraform_validate
which includes more robust handling of terraform's quirks. Given that
there are better solutions out there, we think it's best to remove this
feature from collie and focus our resources on unique features.

Additionally, using "terraform validate" is a bad fit for validating
kit modules as it has big problems with configuration_aliases
hashicorp/terraform#28490
It seems that it is much better suited to validating platform modules instead.
@JohannesRudolph JohannesRudolph added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 352f17a Aug 28, 2024
3 checks passed
@JohannesRudolph JohannesRudolph deleted the feature/tofu-support branch August 28, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant