Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Use relative script paths instead of symlinks #163

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[test] Use relative script paths instead of symlinks #163

merged 1 commit into from
Jan 22, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Jan 20, 2024

Fixes #162 "symlinks are causing issues on Windows"

@jwnimmer-tri jwnimmer-tri changed the title Remove symlinks [test] Use relative script paths instead of symlinks Jan 22, 2024
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

+@SeanCurtis-TRI for second / platform review, please.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SeanCurtis-TRI)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One file missing.

Reviewed 3 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nhz2)

a discussion (no related file):
You're missing webxr.html.


Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: Once I stopped being foolish.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nhz2)

a discussion (no related file):

Previously, SeanCurtis-TRI (Sean Curtis) wrote…

You're missing webxr.html.

Never mind. It's missing because it's already a relative path.


@SeanCurtis-TRI SeanCurtis-TRI merged commit 97b5375 into meshcat-dev:master Jan 22, 2024
@nhz2 nhz2 deleted the remove-symlinks branch January 22, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symlinks are causing issues on Windows
3 participants