Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlinks are causing issues on Windows #162

Closed
nhz2 opened this issue Jan 20, 2024 · 7 comments · Fixed by #163
Closed

symlinks are causing issues on Windows #162

nhz2 opened this issue Jan 20, 2024 · 7 comments · Fixed by #163
Assignees

Comments

@nhz2
Copy link
Contributor

nhz2 commented Jan 20, 2024

Hello,
Thank you for maintaining this viewer. I am using it to view and debug simulations.

There are two symlinks in the test directory, test/main.js => ../dist/main.js and test/main.min.js => ../dist/main.min.js
These are preventing me from running the examples in the test directory on Windows, because Windows by default cannot create symlinks. This is also a issue for people trying to install the julia package on Windows Ref: rdeits/MeshCat.jl#249

Can the symlinks be deleted and the <script src="main.min.js"></script> be replaced with <script src="../dist/main.min.js"></script>
in the tests? I would be happy to make a PR.

@jwnimmer-tri
Copy link
Contributor

That seems OK to me. WDYT @SeanCurtis-TRI?

@nhz2
Copy link
Contributor Author

nhz2 commented Jan 22, 2024

Can there be a new release for this version?

@SeanCurtis-TRI
Copy link
Contributor

Hmmm.... I'm not sure what it means to have a release for meshcat. The only tag we have is from August, 2021.

@nhz2 Did you have something particular in mind?

@jwnimmer-tri
Copy link
Contributor

We haven't been tagging releases. I believe most people just use the git sha. That said, we should probably do another release tag at some point, since the current tag is so old.

In any case, fixes to tests only don't seem to merit a new release on their, do they? Fixes to tests only affect developers and contributors, not end-users. Releases don't typically encompass tests, especially manual hero tests, do they?

@nhz2
Copy link
Contributor Author

nhz2 commented Jan 22, 2024

The Julia package requires a URL to download a tarball with known sha256 hash, and it seems like releases are a way to make those. https://docs.github.com/en/repositories/working-with-files/using-files/downloading-source-code-archives#stability-of-source-code-archives

But since this is specific to Julia, the tarball of this repo could go on a release of MeshCat.jl as well.

@jwnimmer-tri
Copy link
Contributor

Ah, for checksum stability you need not only a release, but a source attachment to the release. See for example the most recent numpy release:

https://github.com/numpy/numpy/releases/tag/v1.26.3

The Source code (tar.gz) does not have a stable checksum. Only an attachment like numpy-1.26.3.tar.gz is invariant.

@jwnimmer-tri
Copy link
Contributor

Tracking at => #164 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants