feat: Cache key uses repo.org only if USE_CONFIG_FROM_PULL_REQUEST is disabled. #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the cache key to repo.org if only global mergeable configuration can be used. Before this change, mergeable would already cache the org config for each repo, but would always use the org/repo cache key. Unfortunately if only global repository is used, this leads to a lot of cache misses if PRs are opened across many repositories within the organization.
mhflink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the cache key to repo.org if only global mergeable configuration can be used.
This logic applies only in a combination of
Before this change, mergeable would already cache the org config for each repo, but would always use the org/repo cache key. Unfortunately if only global repository is used, this leads to a lot of cache misses if PRs are opened across many repositories within the organization.
In our case, the current behavior let to us being rate-limited by GitHub.