Update #1
Update #1
Conversation
faire2
commented
Mar 11, 2022
faire2
commented
- updatovany ikony
- pridany nove komponenty (resp. styly pro ne)
- updatovany dependencies
js/webpack.config.js
Outdated
| path.join( | ||
| __dirname, | ||
| '..', | ||
| 'sass/muil.sass', | ||
| ) |
There was a problem hiding this comment.
__dirname + '../sass/... bude imho přehlednější. S lomítkama na windows problémy myslím nejsou (nikdy sem je neřešil)
There was a problem hiding this comment.
Rád to změním, ale jde to proti tomuhle:
As a lot of answers have pointed out, using path module is probably the best way. However, most of the solutions here have gone back to using slashes like:
path.join(__dirname+'../test/karma.conf.js')
However, by doing this, you're beating the purpose of using path. One uses path to do operations irrespective of the underlying OS (Linux, Windows etc). Just to give a bit of insight, you can do the path operations directly as string operations (like __dirname + '../test/karma.conf.js'. You do not do this because Linux uses forward slashes ( / ), Windows uses backward slashes ( \ ). This makes your application prone to errors when you port it across operating systems.
https://stackoverflow.com/questions/30845416/how-to-go-back-1-folder-level-with-dirname
There was a problem hiding this comment.
tak v tom případě path.join(__dirname, '..', 'sass', 'muil.sass') aby to mělo smysl? A teda všude?
js/webpack.config.js
Outdated
| }, | ||
| output: { | ||
| path: __dirname + '/../build', | ||
| filename: '[name].min.js', | ||
| }, | ||
| optimization: { | ||
| chunkIds: 'total-size', moduleIds: 'size' |
There was a problem hiding this comment.
jednu property na řádek a trailing comma pls
There was a problem hiding this comment.
Projdi prosím diffy jednotlivých ikon a zkus je minmalizovat.
Popravdě netuším moc jak důležitý viewBox vs width & height, ale některé prohlížeče na to byly háklivé a imho by se to nemělo měnit.
Kromě log žádná z ikon nemá fill, to je tu naschvál a dodržoval bych to dál.
Ty cesty v configu udělej jak uznáš za vhodné, jenom ať je to konzistentně.
