Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loadbalancer): prevent nil pointer deref by error handling #138

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

seanschneeweiss
Copy link
Member

@seanschneeweiss seanschneeweiss commented Jan 2, 2024

Eventually the OpenStack API is overloaded and leads to Nil Pointer Dereference.
This PR introduces some error handling for failed calls.

The warning looks like this:

W0102 00:00:17.498806       1 loadbalancer.go:113] Unable to get member 16d09e83-acc5-48e3-a463-c2ebca55ccb4 of pool 2ff62d69-a61f-4d58-9858-477af1c7cb54: The service is currently unable to handle the request due to a temporary overloading or maintenance. This is a temporary condition. Try again later.

@seanschneeweiss seanschneeweiss changed the title fix(loadbalancer): prevent nil pointer by error handling fix(loadbalancer): prevent nil pointer deref by error handling Jan 2, 2024
@seanschneeweiss seanschneeweiss self-assigned this Jan 2, 2024
@seanschneeweiss seanschneeweiss merged commit 985f6de into master Jan 3, 2024
2 checks passed
@seanschneeweiss seanschneeweiss deleted the seaschn/lb-error-handling branch January 3, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants