Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put HPA name to status even when no autoscaling policy is horizontal #399

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

randytqwjp
Copy link
Collaborator

@randytqwjp randytqwjp commented Apr 25, 2024

What this PR does / why we need it:

fix: put HPA name to status even when no autoscaling policy is horizontal

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link
Collaborator

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one nit

pkg/hpa/service_test.go Outdated Show resolved Hide resolved
Co-authored-by: Kensei Nakada <[email protected]>
@sanposhiho sanposhiho merged commit ab706a7 into main Apr 26, 2024
3 checks passed
@sanposhiho sanposhiho deleted the kit-HPA-bug-fix branch April 26, 2024 05:02
@sanposhiho sanposhiho changed the title fix HPA init bug fix: put HPA name to status even when no autoscaling policy is horizontal Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants