implement MaxAllocatedResources and MaxReplicas in Tortoise #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanposhiho
force-pushed
the
maxAllocatedResource-per-container
branch
from
d1e4959 to
92e6b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We do have a global configuration to limit the max replicas or max allocated resource. But, we don't have the knobs that people can limit them per Tortoise/workload.
In our development environment, some people intentionally limit the max resources to save the cost or make less traffic to their downstream services, which is difficult to achieve via a global configuration.
Which issue(s) this PR fixes:
Fixes #293
Special notes for your reviewer: