Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't update HPA spec if off #188

Merged
merged 1 commit into from
Oct 13, 2023
Merged

don't update HPA spec if off #188

merged 1 commit into from
Oct 13, 2023

Conversation

sanposhiho
Copy link
Collaborator

What this PR does / why we need it:

ssia

It means that when dryrun, the spec of HPA might be different from the spec of tortoise.
And in such cases, when people change mode to Auto, the HPA is changed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sanposhiho sanposhiho merged commit 70b2e6d into main Oct 13, 2023
3 checks passed
@sanposhiho sanposhiho deleted the no-update-off branch October 13, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant