add tests for HPA mutating webhook

api/autoscaling/v2/horizontalpodautoscaler_webhook.go

@@ -75,6 +75,11 @@ func (h *HPAWebhook) Default(ctx context.Context, obj runtime.Object) error {
 		return nil
 	}
 
+	if t.Status.Targets.HorizontalPodAutoscaler != hpa.Name {
+		// not managed by tortoise
+		return nil
+	}
+
 	hpa, _, err = h.hpaService.ChangeHPAFromTortoiseRecommendation(t, hpa, time.Now(), false) // we don't need to record metrics.
 	if err != nil {
 		// Block updating HPA may be critical. Just ignore it with error logs.

api/autoscaling/v2/horizontalpodautoscaler_webhook_test.go

@@ -0,0 +1,101 @@
+/*
+MIT License
+
+Copyright (c) 2023 mercari
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+*/
+
+package autoscalingv2
+
+import (
+	"bytes"
+	"context"
+	"os"
+	"path/filepath"
+
+	v2 "k8s.io/api/autoscaling/v2"
+	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/apimachinery/pkg/util/yaml"
+
+	"github.com/mercari/tortoise/api/v1beta1"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func mutateTest(before, after, torotise string) {
+	ctx := context.Background()
+
+	y, err := os.ReadFile(torotise)
+	Expect(err).NotTo(HaveOccurred())
+	tor := &v1beta1.Tortoise{}
+	err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(tor)
+	status := tor.Status
+	Expect(err).NotTo(HaveOccurred())
+	err = k8sClient.Create(ctx, tor)
+	Expect(err).NotTo(HaveOccurred())
+	defer func() {
+		err = k8sClient.Delete(ctx, tor)
+		Expect(err).NotTo(HaveOccurred())
+	}()
+	tor.Status = status
+	//nolint:errcheck
+	k8sClient.Status().Update(ctx, tor)
+
+	y, err = os.ReadFile(before)
+	Expect(err).NotTo(HaveOccurred())
+	beforehpa := &v2.HorizontalPodAutoscaler{}
+	err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(beforehpa)
+	Expect(err).NotTo(HaveOccurred())
+	err = k8sClient.Create(ctx, beforehpa)
+	Expect(err).NotTo(HaveOccurred())
+	defer func() {
+		err = k8sClient.Delete(ctx, beforehpa)
+		Expect(err).NotTo(HaveOccurred())
+	}()
+
+	ret := &v2.HorizontalPodAutoscaler{}
+	err = k8sClient.Get(ctx, types.NamespacedName{Name: beforehpa.GetName(), Namespace: beforehpa.GetNamespace()}, ret)
+	Expect(err).NotTo(HaveOccurred())
+
+	y, err = os.ReadFile(after)
+	Expect(err).NotTo(HaveOccurred())
+	afterhpa := &v2.HorizontalPodAutoscaler{}
+	err = yaml.NewYAMLOrJSONDecoder(bytes.NewReader(y), 4096).Decode(afterhpa)
+	Expect(err).NotTo(HaveOccurred())
+
+	Expect(ret.Spec).Should(Equal(afterhpa.Spec))
+}
+
+var _ = Describe("v2.HPA Webhook", func() {
+	Context("mutating", func() {
+		It("nothing to do", func() {
+			mutateTest(filepath.Join("testdata", "mutating", "nothing-to-do", "before.yaml"), filepath.Join("testdata", "mutating", "nothing-to-do", "after.yaml"), filepath.Join("testdata", "mutating", "nothing-to-do", "tortoise.yaml"))
+		})
+		It("HPA is mutated based on the recommendation", func() {
+			mutateTest(filepath.Join("testdata", "mutating", "mutate-by-recommendations", "before.yaml"), filepath.Join("testdata", "mutating", "mutate-by-recommendations", "after.yaml"), filepath.Join("testdata", "mutating", "mutate-by-recommendations", "tortoise.yaml"))
+		})
+		It("HPA is not mutated because of invalid annotation", func() {
+			mutateTest(filepath.Join("testdata", "mutating", "has-annotation-but-invalid1", "before.yaml"), filepath.Join("testdata", "mutating", "has-annotation-but-invalid1", "after.yaml"), filepath.Join("testdata", "mutating", "has-annotation-but-invalid1", "tortoise.yaml"))
+			mutateTest(filepath.Join("testdata", "mutating", "has-annotation-but-invalid2", "before.yaml"), filepath.Join("testdata", "mutating", "has-annotation-but-invalid2", "after.yaml"), filepath.Join("testdata", "mutating", "has-annotation-but-invalid2", "tortoise.yaml"))
+		})
+	})
+})

api/autoscaling/v2/testdata/mutating/has-annotation-but-invalid1/after.yaml

@@ -0,0 +1,29 @@
+apiVersion: autoscaling/v2
+kind: HorizontalPodAutoscaler
+metadata:
+  name: sample
+  namespace: default
+  annotations:
+    tortoises.autoscaling.mercari.com/tortoise-name: invalid
+spec:
+  maxReplicas: 10
+  metrics:
+    - type: ContainerResource
+      containerResource:
+        name: cpu
+        container: nginx
+        target:
+          type: Utilization
+          averageUtilization: 60
+    - type: ContainerResource
+      containerResource:
+        name: cpu
+        container: istio-proxy
+        target:
+          type: Utilization
+          averageUtilization: 60
+  minReplicas: 1
+  scaleTargetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: sample

api/autoscaling/v2/testdata/mutating/has-annotation-but-invalid1/before.yaml

@@ -0,0 +1,29 @@
+apiVersion: autoscaling/v2
+kind: HorizontalPodAutoscaler
+metadata:
+  name: sample
+  namespace: default
+  annotations:
+    tortoises.autoscaling.mercari.com/tortoise-name: invalid
+spec:
+  maxReplicas: 10
+  metrics:
+    - type: ContainerResource
+      containerResource:
+        name: cpu
+        container: nginx
+        target:
+          type: Utilization
+          averageUtilization: 60
+    - type: ContainerResource
+      containerResource:
+        name: cpu
+        container: istio-proxy
+        target:
+          type: Utilization
+          averageUtilization: 60
+  minReplicas: 1
+  scaleTargetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: sample