fix: use proposed_memory_request for recording memory request (#127)

mercari · Oct 3, 2023 · 885061e · 885061e
1 parent abbc3e5
commit 885061e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -23,12 +23,12 @@ var (
 
 	ProposedCPURequest = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 		Name: "proposed_cpu_request",
-		Help: "recommended resource request that tortoises propose",
+		Help: "recommended cpu request (millicore) that tortoises propose",
 	}, []string{"tortoise_name", "namespace", "container_name"})
 
 	ProposedMemoryRequest = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 		Name: "proposed_memory_request",
-		Help: "recommended resource request that tortoises propose",
+		Help: "recommended memory request (millibyte) that tortoises propose",
 	}, []string{"tortoise_name", "namespace", "container_name"})
 )
 

diff --git a/pkg/vpa/service.go b/pkg/vpa/service.go
@@ -212,7 +212,7 @@ func (c *Service) UpdateVPAFromTortoiseRecommendation(ctx context.Context, torto
 						metrics.ProposedCPURequest.WithLabelValues(tortoise.Name, tortoise.Namespace, r.ContainerName).Set(float64(value.MilliValue()))
 					}
 					if resourcename == corev1.ResourceMemory {
-						metrics.ProposedCPURequest.WithLabelValues(tortoise.Name, tortoise.Namespace, r.ContainerName).Set(float64(value.MilliValue()))
+						metrics.ProposedMemoryRequest.WithLabelValues(tortoise.Name, tortoise.Namespace, r.ContainerName).Set(float64(value.MilliValue()))
 					}
 				}
 				metricsRecorded = true