add: applied_hpa_utilization_target metric (#179)

mercari · Oct 12, 2023 · 60bee81 · 60bee81
1 parent 3232c2e
commit 60bee81
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/pkg/hpa/service.go b/pkg/hpa/service.go
@@ -368,6 +368,10 @@ func (c *Service) ChangeHPAFromTortoiseRecommendation(tortoise *autoscalingv1bet
 				continue
 			}
 
+			if allowed && tortoise.Spec.UpdateMode != autoscalingv1beta2.UpdateModeOff {
+				metrics.AppliedHPATargetUtilization.WithLabelValues(tortoise.Name, tortoise.Namespace, t.ContainerName, resourcename.String(), hpa.Name).Set(float64(proposedTarget))
+			}
+
 			if err := c.updateHPATargetValue(hpa, t.ContainerName, resourcename, proposedTarget); err != nil {
 				return nil, tortoise, fmt.Errorf("update HPA from the recommendation from tortoise")
 			}

diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -6,6 +6,11 @@ import (
 )
 
 var (
+	AppliedHPATargetUtilization = prometheus.NewGaugeVec(prometheus.GaugeOpts{
+		Name: "applied_hpa_utilization_target",
+		Help: "hpa utilization target values that tortoises actually applys to hpa",
+	}, []string{"tortoise_name", "namespace", "container_name", "resource_name", "hpa_name"})
+
 	ProposedHPATargetUtilization = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 		Name: "proposed_hpa_utilization_target",
 		Help: "recommended hpa utilization target values that tortoises propose",
@@ -35,6 +40,7 @@ var (
 func init() {
 	//Register metrics with prometheus
 	metrics.Registry.MustRegister(
+		AppliedHPATargetUtilization,
 		ProposedHPATargetUtilization,
 		ProposedHPAMinReplicass,
 		ProposedHPAMaxReplicass,