refactor: file-based controller tests

mercari · Oct 6, 2023 · 54fe86f · 54fe86f
1 parent 1753133
commit 54fe86f
Show file tree

Hide file tree

Showing 78 changed files with 3,549 additions and 2,288 deletions.
diff --git a/controllers/suite_test.go b/controllers/suite_test.go
@@ -72,7 +72,7 @@ var _ = BeforeSuite(func() {
 
 	By("bootstrapping test environment")
 	testEnv = &envtest.Environment{
-		CRDDirectoryPaths:     []string{filepath.Join("..", "config", "crd", "bases"), filepath.Join("testdata")},
+		CRDDirectoryPaths:     []string{filepath.Join("..", "config", "crd", "bases"), filepath.Join("testdata", "crd")},
 		ErrorIfCRDPathMissing: true,
 	}
 

diff --git a/controllers/testdata/vpa-v1-crd-gen.yaml → controllers/testdata/crd/vpa-v1-crd-gen.yaml b/controllers/testdata/vpa-v1-crd-gen.yaml → controllers/testdata/crd/vpa-v1-crd-gen.yaml
@@ -4,7 +4,6 @@ metadata:
   annotations:
     api-approved.kubernetes.io: https://github.com/kubernetes/kubernetes/pull/63797
     controller-gen.kubebuilder.io/version: v0.9.2
-  creationTimestamp: null
   name: verticalpodautoscalercheckpoints.autoscaling.k8s.io
 spec:
   group: autoscaling.k8s.io
@@ -210,7 +209,6 @@ metadata:
   annotations:
     api-approved.kubernetes.io: https://github.com/kubernetes/kubernetes/pull/63797
     controller-gen.kubebuilder.io/version: v0.9.2
-  creationTimestamp: null
   name: verticalpodautoscalers.autoscaling.k8s.io
 spec:
   group: autoscaling.k8s.io

diff --git a/controllers/testdata/deletion-no-delete/before/deployment.yaml b/controllers/testdata/deletion-no-delete/before/deployment.yaml
@@ -0,0 +1,30 @@
+metadata:
+  creationTimestamp: null
+  name: mercari-app
+  namespace: default
+spec:
+  selector:
+    matchLabels:
+      app: mercari
+  strategy: {}
+  template:
+    metadata:
+      creationTimestamp: null
+      labels:
+        app: mercari
+    spec:
+      containers:
+      - image: awesome-mercari-app-image
+        name: app
+        resources:
+          requests:
+            cpu: "10"
+            memory: 10Gi
+      - image: awesome-istio-proxy-image
+        name: istio-proxy
+        resources:
+          requests:
+            cpu: "4"
+            memory: 4Gi
+status:
+  replicas: 10
diff --git a/controllers/testdata/deletion-no-delete/before/hpa.yaml b/controllers/testdata/deletion-no-delete/before/hpa.yaml
@@ -0,0 +1,46 @@
+metadata:
+  annotations:
+    tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
+    tortoises.autoscaling.mercari.com/tortoise-name: mercari
+  creationTimestamp: null
+  name: tortoise-hpa-mercari
+  namespace: default
+spec:
+  behavior:
+    scaleDown:
+      policies:
+      - periodSeconds: 90
+        type: Percent
+        value: 2
+      selectPolicy: Max
+    scaleUp:
+      policies:
+      - periodSeconds: 60
+        type: Percent
+        value: 100
+      selectPolicy: Max
+      stabilizationWindowSeconds: 0
+  maxReplicas: 100
+  metrics:
+  - containerResource:
+      container: app
+      name: cpu
+      target:
+        averageUtilization: 50
+        type: Utilization
+    type: ContainerResource
+  - containerResource:
+      container: istio-proxy
+      name: cpu
+      target:
+        averageUtilization: 50
+        type: Utilization
+    type: ContainerResource
+  minReplicas: 1
+  scaleTargetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: mercari-app
+status:
+  currentMetrics: null
+  desiredReplicas: 0
diff --git a/controllers/testdata/deletion-no-delete/before/tortoise.yaml b/controllers/testdata/deletion-no-delete/before/tortoise.yaml
@@ -0,0 +1,88 @@
+metadata:
+  creationTimestamp: null
+  name: mercari
+  namespace: default
+spec:
+  deletionPolicy: NoDelete
+  resourcePolicy:
+  - autoscalingPolicy:
+      cpu: Horizontal
+      memory: Vertical
+    containerName: app
+  - autoscalingPolicy:
+      cpu: Horizontal
+      memory: Vertical
+    containerName: istio-proxy
+  targetRefs:
+    scaleTargetRef:
+      apiVersion: apps/v1
+      kind: Deployment
+      name: mercari-app
+status:
+  conditions:
+    containerRecommendationFromVPA:
+    - containerName: app
+      maxRecommendation:
+        cpu:
+          quantity: "0"
+          updatedAt: null
+        memory:
+          quantity: "0"
+          updatedAt: null
+      recommendation:
+        cpu:
+          quantity: "0"
+          updatedAt: null
+        memory:
+          quantity: "0"
+          updatedAt: null
+    - containerName: istio-proxy
+      maxRecommendation:
+        cpu:
+          quantity: "0"
+          updatedAt: null
+        memory:
+          quantity: "0"
+          updatedAt: null
+      recommendation:
+        cpu:
+          quantity: "0"
+          updatedAt: null
+        memory:
+          quantity: "0"
+          updatedAt: null
+    tortoiseConditions: null
+  recommendations:
+    horizontal:
+      maxReplicas:
+      - from: 0
+        timezone: Local
+        to: 24
+        updatedAt: "2023-10-06T01:32:21Z"
+        value: 15
+        weekday: Friday
+      minReplicas:
+      - from: 0
+        timezone: Local
+        to: 24
+        updatedAt: "2023-10-06T01:32:21Z"
+        value: 3
+        weekday: Friday
+      targetUtilizations:
+      - containerName: app
+        targetUtilization:
+          cpu: 50
+      - containerName: istio-proxy
+        targetUtilization:
+          cpu: 50
+    vertical:
+      containerResourceRecommendation: null
+  targets:
+    deployment: ""
+    horizontalPodAutoscaler: tortoise-hpa-mercari
+    verticalPodAutoscalers:
+    - name: tortoise-updater-mercari
+      role: Updater
+    - name: tortoise-monitor-mercari
+      role: Monitor
+  tortoisePhase: Working
diff --git a/controllers/testdata/deletion-no-delete/before/vpa-Monitor.yaml b/controllers/testdata/deletion-no-delete/before/vpa-Monitor.yaml
@@ -0,0 +1,45 @@
+metadata:
+  annotations:
+    tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
+    tortoises.autoscaling.mercari.com/tortoise-name: mercari
+  creationTimestamp: null
+  name: tortoise-monitor-mercari
+  namespace: default
+spec:
+  resourcePolicy:
+    containerPolicies:
+    - containerName: app
+    - containerName: istio-proxy
+  targetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: mercari-app
+  updatePolicy:
+    updateMode: "Off"
+status:
+  conditions:
+  - lastTransitionTime: null
+    status: "True"
+    type: RecommendationProvided
+  recommendation:
+    containerRecommendations:
+    - containerName: app
+      lowerBound:
+        cpu: "3"
+        memory: 3Gi
+      target:
+        cpu: "3"
+        memory: 3Gi
+      upperBound:
+        cpu: "5"
+        memory: 5Gi
+    - containerName: istio-proxy
+      lowerBound:
+        cpu: "3"
+        memory: 3Gi
+      target:
+        cpu: "3"
+        memory: 3Gi
+      upperBound:
+        cpu: "5"
+        memory: 5Gi
diff --git a/controllers/testdata/deletion-no-delete/before/vpa-Updater.yaml b/controllers/testdata/deletion-no-delete/before/vpa-Updater.yaml
@@ -0,0 +1,21 @@
+metadata:
+  annotations:
+    tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
+    tortoises.autoscaling.mercari.com/tortoise-name: mercari
+  creationTimestamp: null
+  name: tortoise-updater-mercari
+  namespace: default
+spec:
+  recommenders:
+  - name: tortoise-controller
+  resourcePolicy:
+    containerPolicies:
+    - containerName: app
+    - containerName: istio-proxy
+  targetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: mercari-app
+  updatePolicy:
+    updateMode: Auto
+status: {}
diff --git a/controllers/testdata/deletion-policy-all/before/deployment.yaml b/controllers/testdata/deletion-policy-all/before/deployment.yaml
@@ -0,0 +1,30 @@
+metadata:
+  creationTimestamp: null
+  name: mercari-app
+  namespace: default
+spec:
+  selector:
+    matchLabels:
+      app: mercari
+  strategy: {}
+  template:
+    metadata:
+      creationTimestamp: null
+      labels:
+        app: mercari
+    spec:
+      containers:
+      - image: awesome-mercari-app-image
+        name: app
+        resources:
+          requests:
+            cpu: "10"
+            memory: 10Gi
+      - image: awesome-istio-proxy-image
+        name: istio-proxy
+        resources:
+          requests:
+            cpu: "4"
+            memory: 4Gi
+status:
+  replicas: 10
diff --git a/controllers/testdata/deletion-policy-all/before/hpa.yaml b/controllers/testdata/deletion-policy-all/before/hpa.yaml
@@ -0,0 +1,46 @@
+metadata:
+  annotations:
+    tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
+    tortoises.autoscaling.mercari.com/tortoise-name: mercari
+  creationTimestamp: null
+  name: tortoise-hpa-mercari
+  namespace: default
+spec:
+  behavior:
+    scaleDown:
+      policies:
+      - periodSeconds: 90
+        type: Percent
+        value: 2
+      selectPolicy: Max
+    scaleUp:
+      policies:
+      - periodSeconds: 60
+        type: Percent
+        value: 100
+      selectPolicy: Max
+      stabilizationWindowSeconds: 0
+  maxReplicas: 100
+  metrics:
+  - containerResource:
+      container: app
+      name: cpu
+      target:
+        averageUtilization: 50
+        type: Utilization
+    type: ContainerResource
+  - containerResource:
+      container: istio-proxy
+      name: cpu
+      target:
+        averageUtilization: 50
+        type: Utilization
+    type: ContainerResource
+  minReplicas: 1
+  scaleTargetRef:
+    apiVersion: apps/v1
+    kind: Deployment
+    name: mercari-app
+status:
+  currentMetrics: null
+  desiredReplicas: 0