ignore empty env value in golang env (#369)

mercari · Feb 28, 2024 · 3d1c629 · 3d1c629
1 parent 6716425
commit 3d1c629
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/pkg/pod/pod.go b/pkg/pod/pod.go
@@ -116,6 +116,10 @@ func (s *Service) ModifyPodResource(pod *v1.Pod, t *v1beta3.Tortoise) {
 				if !ok {
 					continue
 				}
+				if len(env.Value) == 0 {
+					// Probably it's defined through the configmap.
+					continue
+				}
 				oldNum, err := strconv.Atoi(env.Value)
 				if err != nil {
 					// invalid GOMAXPROCS, skip
@@ -137,6 +141,10 @@ func (s *Service) ModifyPodResource(pod *v1.Pod, t *v1beta3.Tortoise) {
 					continue
 				}
 				val := env.Value
+				if len(val) == 0 {
+					// Probably it's defined through the configmap.
+					continue
+				}
 				last := val[len(val)-1]
 				if last >= '0' && last <= '9' {
 					// OK