refactor tortoisephase change into tortoise service and write unit tests

mercari · Dec 12, 2024 · 2e261c4 · 2e261c4
1 parent dd7c10a
commit 2e261c4
Show file tree

Hide file tree

Showing 46 changed files with 905 additions and 67 deletions.
diff --git a/internal/controller/testdata/deletion-no-delete/before/hpa.yaml b/internal/controller/testdata/deletion-no-delete/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/internal/controller/testdata/deletion-policy-all/before/hpa.yaml b/internal/controller/testdata/deletion-policy-all/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/internal/controller/testdata/mutable-autoscalingpolicy-add-another-horizontal/after/hpa.yaml b/internal/controller/testdata/mutable-autoscalingpolicy-add-another-horizontal/after/hpa.yaml
@@ -47,5 +47,21 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
diff --git a/...rnal/controller/testdata/mutable-autoscalingpolicy-add-another-horizontal/before/hpa.yaml b/...rnal/controller/testdata/mutable-autoscalingpolicy-add-another-horizontal/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/internal/controller/testdata/mutable-autoscalingpolicy-remove-horizontal-2/after/hpa.yaml b/internal/controller/testdata/mutable-autoscalingpolicy-remove-horizontal-2/after/hpa.yaml
@@ -32,5 +32,21 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
diff --git a/internal/controller/testdata/mutable-autoscalingpolicy-remove-horizontal-2/before/hpa.yaml b/internal/controller/testdata/mutable-autoscalingpolicy-remove-horizontal-2/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/internal/controller/testdata/mutable-autoscalingpolicy-remove-horizontal/before/hpa.yaml b/internal/controller/testdata/mutable-autoscalingpolicy-remove-horizontal/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/internal/controller/testdata/reconcile-for-the-istio-enabled-pod-working/after/hpa.yaml b/internal/controller/testdata/reconcile-for-the-istio-enabled-pod-working/after/hpa.yaml
@@ -40,5 +40,21 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
diff --git a/internal/controller/testdata/reconcile-for-the-istio-enabled-pod-working/before/hpa.yaml b/internal/controller/testdata/reconcile-for-the-istio-enabled-pod-working/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/...roller/testdata/reconcile-for-the-multiple-containers-pod-during-emergency/after/hpa.yaml b/...roller/testdata/reconcile-for-the-multiple-containers-pod-during-emergency/after/hpa.yaml
@@ -40,5 +40,21 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
diff --git a/...oller/testdata/reconcile-for-the-multiple-containers-pod-during-emergency/before/hpa.yaml b/...oller/testdata/reconcile-for-the-multiple-containers-pod-during-emergency/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/...oller/testdata/reconcile-for-the-multiple-containers-pod-emergency-started/after/hpa.yaml b/...oller/testdata/reconcile-for-the-multiple-containers-pod-emergency-started/after/hpa.yaml
@@ -40,5 +40,21 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
diff --git a/...ller/testdata/reconcile-for-the-multiple-containers-pod-emergency-started/before/hpa.yaml b/...ller/testdata/reconcile-for-the-multiple-containers-pod-emergency-started/before/hpa.yaml
@@ -3,6 +3,25 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/...rnal/controller/testdata/reconcile-for-the-multiple-containers-pod-one-off/after/hpa.yaml b/...rnal/controller/testdata/reconcile-for-the-multiple-containers-pod-one-off/after/hpa.yaml
@@ -33,5 +33,16 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
diff --git a/...nal/controller/testdata/reconcile-for-the-multiple-containers-pod-one-off/before/hpa.yaml b/...nal/controller/testdata/reconcile-for-the-multiple-containers-pod-one-off/before/hpa.yaml
@@ -3,6 +3,20 @@ metadata:
     tortoise.autoscaling.mercari.com/managed-by-tortoise: "true"
   name: tortoise-hpa-mercari
   namespace: default
+status:
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
 spec:
   behavior:
     scaleDown:

diff --git a/...ler/testdata/reconcile-for-the-multiple-containers-pod-suggested-too-small/after/hpa.yaml b/...ler/testdata/reconcile-for-the-multiple-containers-pod-suggested-too-small/after/hpa.yaml
@@ -40,5 +40,21 @@ spec:
     kind: Deployment
     name: mercari-app
 status:
-  currentMetrics: null
-  desiredReplicas: 0
+  conditions:
+    - status: "True"
+      type: AbleToScale
+      message: "recommended size matches current size"
+    - status: "True"
+      type: ScalingActive
+      message: "the HPA was able to compute the replica count"
+  currentMetrics:
+    - containerResource:
+        container: app
+        name: cpu
+        current:
+          value: 3
+    - containerResource:
+        container: istio-proxy
+        name: cpu
+        current:
+          value: 3