Skip to content

Commit

Permalink
Merge pull request #103 from KeisukeYamashita/fix-user-defined-substi…
Browse files Browse the repository at this point in the history
…tutions

Fix region user defined substitution format
  • Loading branch information
KeisukeYamashita authored Jan 17, 2022
2 parents 4ada7e7 + eafff07 commit eae67cd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ci.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func cloudbuild() (ci CI, err error) {
ci.PR.Number = 0
ci.PR.Revision = os.Getenv("COMMIT_SHA")

region := os.Getenv("REGION")
region := os.Getenv("_REGION")
if region == "" {
region = defaultCloudBuildRegion
}
Expand Down
4 changes: 2 additions & 2 deletions ci_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ func TestCloudBuild(t *testing.T) {
os.Setenv("BUILD_ID", "build-id")
os.Setenv("PROJECT_ID", "gcp-project-id")
os.Setenv("_PR_NUMBER", "123")
os.Setenv("REGION", "asia-northeast1")
os.Setenv("_REGION", "asia-northeast1")
},
ci: CI{
PR: PullRequest{
Expand All @@ -808,7 +808,7 @@ func TestCloudBuild(t *testing.T) {
os.Setenv("BUILD_ID", "build-id")
os.Setenv("PROJECT_ID", "gcp-project-id")
os.Setenv("_PR_NUMBER", "")
os.Setenv("REGION", "")
os.Setenv("_REGION", "")
},
ci: CI{
PR: PullRequest{
Expand Down

0 comments on commit eae67cd

Please sign in to comment.