Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: Make client-go rate limiter params configurable #4

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

tfujiwar
Copy link
Collaborator

@tfujiwar tfujiwar commented Nov 21, 2024

  • Make client-go rate limiter params configurable.
  • Add logs to EpehemralRunnerReconciler.

@tfujiwar tfujiwar changed the title gha: customize client-go rate limiter params gha: Make client-go rate limiter params configurable Nov 21, 2024
@tfujiwar tfujiwar marked this pull request as ready for review November 21, 2024 00:46
Comment on lines +162 to +163
flag.IntVar(&rateLimiterQPS, "client-go-rate-limiter-qps", 20, "The QPS value of client-go rate limiter.")
flag.IntVar(&rateLimiterBurst, "client-go-rate-limiter-burst", 30, "The burst value of client-go rate limiter.")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfujiwar tfujiwar merged commit 8728190 into mercari-master Nov 21, 2024
9 checks passed
@tfujiwar tfujiwar deleted the tfujiwar-rate-limiter-params branch November 21, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants