-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added --third-party-subscriptions argument in rele-cli run command #269
Merged
awaistkd
merged 23 commits into
master
from
add-discoverable-packages-argument-to-run-rele-command
Jan 22, 2024
Merged
Added --third-party-subscriptions argument in rele-cli run command #269
awaistkd
merged 23 commits into
master
from
add-discoverable-packages-argument-to-run-rele-command
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaistkd
requested review from
daniel-ruiz,
EmilioCarrion,
AdamjGoddard,
jonasae and
a team
as code owners
January 19, 2024 10:43
igarridot
reviewed
Jan 19, 2024
awaistkd
changed the title
Added --third-party-discoverable-packages argument in rele-cli run command
Added --third-party-subscriptions argument in rele-cli run command
Jan 19, 2024
jBonoraW
reviewed
Jan 19, 2024
jBonoraW
approved these changes
Jan 22, 2024
awaistkd
deleted the
add-discoverable-packages-argument-to-run-rele-command
branch
January 22, 2024 09:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Added
--third-party-subscriptions
argument inrele-cli run
command which will allow us to pass subscriptions from the third-party packages.🤔 Why?
When we run
python manage.py runrele
command, the Rele is able to automatically discover the subscriptions from the installed third-party packages if they are added to theINSTALLED_APPS
.We need the possibility to run the subscriptions from a third-party package with the
rele-cli run
command .🔗 Related issue
Related issue --> #266