[coverity] Suppress false positive. SX#GULBI-122

[martyone]

No description provided.

[monich]

Just out of curiosity, what coverity complained about?

[martyone]

[monich]

I really don't get it - disconnected is checked as a loop condition and decremented at the bottom of the loop, how can it possibly overflow. And what is this disconnected = disconnected, its value is now whatever. That doesn't make any sense, does it?

[monich]

On the other hand, this disconnected count isn't really necessary (afaict it's just a micro-optimization for early termination of the loop) and can be removed without much of an impact. It would also make sense to remove the GBinderServiceManagerWatch entry when its last handler is gone. Let me try to rewrite this function in a way that makes coverity happier.

[martyone]

I really don't get it - disconnected is checked as a loop condition and decremented at the bottom of the loop, how can it possibly overflow. And what is this disconnected = disconnected, its value is now whatever. That doesn't make any sense, does it?

Yes, it's clearly a false positive. Bug in the tool.

[monich]

BTW, what is this SX#GULBI thing? Looks like some sort of a magic necessary for the build to get through the build automation. Is it required? Does the old JB# magic still work?

[mkosola]

BTW, what is this SX#GULBI thing? Looks like some sort of a magic necessary for the build to get through the build automation. Is it required? Does the old JB# magic still work?

@monich JB# is still used, SX# is just another similar bug reference code for different projects

[monich]

#141 is what I suggest instead