-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpi-update-firmware.bbclass: refactor rpi_install_firmware_to_rootfs #2114
base: master
Are you sure you want to change the base?
Conversation
The current rpi_install_firmware_to_rootfs has several problems: - it's installing duplicated devicetrees to /boot/firmware, because it is installing all dtb/dtbo links but they are duplicated, for instance: uart2.dtbo and uart2-raspberrypi4-64.dtbo are pointing to a same file. - While RPI bootfs contains all files listed in IMAGE_BOOT_FILES, a end user can customize that variable to install the files they want to be in boot partition, but rpi_install_firmware_to_rootfs does not handle it. To fix the above, introduce a function mender_install_deployed_files which is implemented in the same way with how WIC handle IMAGE_BOOT_FILES, now the files in boot partition and the files in /boot/firmware of A/B partitions are consistent. Signed-off-by: Ming Liu <[email protected]>
befdbd3
to
86e0949
Compare
Hello @liuming50 and thank you for your contribution! Sorry that we are a bit busy in our end and I haven't looked at this one yet 🙈 @TheYoctoJester can you please review this PR? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build tested successfully.
@lluiscampos, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
Hi @liuming50, care to resolve the conflict so we can merge this? |
Actually, we have removed this layer from So we need to port this patch to https://github.com/mendersoftware/meta-mender-community/ @liuming50 I am sorry that we have not warned you about this before! |
The current rpi_install_firmware_to_rootfs has several problems:
To fix the above, introduce a function mender_install_deployed_files which is implemented in the same way with how WIC handle IMAGE_BOOT_FILES, now the files in boot partition and the files in /boot/firmware of A/B partitions are consistent.
External Contributor Checklist
🚨 Please review the guidelines for contributing to this repository.
The majority of our contributions are fixes, which means your commit should have
the form below:
git --signoff
. Also note that the signoff author must match the author of the commit.Description
Please describe your pull request.
Thank you!