struct Av1Block: Replace Rust enum with separate tag and union
#1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
requested changes
Jul 22, 2024
|
Turns out we don't need this, I didn't get the right combination (#1333) of reprs that reduced the size to 32 |
kkysen
added a commit
that referenced
this pull request
Jul 22, 2024
…tes (#1333) This is a simpler, fully safe alternative to #1331. It reduces `Av1BlockIntraInter` from 28 to 24 bytes, and `Av1Block` from 36 to 32 bytes, just like #1331. I haven't checked memory usage, though, since I'm not sure how to do that, but since it reduces the type sizes the same, I assume it would have the same memory savings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves 4 bytes x number of Av1Block allocations by making
Av1Block32 bytes instead of 36. We can't just make the previousiifield a Rust enum with a 1-byte discriminant because the contents must be 2-byte aligned due toMvneeding that alignment.On Chimera 8-bit this saves about 2% of the total heap usage.