CLI option to toggle gdb breakOnStart #2178
Open
+62
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this patch quite useful in the time that I've spent debugging startup problems in homebrew--it is much easier to add/remove a command line flag and begin running the game rather than having to startup gdb, connect to localhost and continue running.
I avoided adding global state with this patch, although the code for passing arguments from the frontend to the emulator feels a bit messy. Maybe it should be refactored a bit, adding a more extendable way of passing arguments down? Although that may be beyond the scope of this PR.