-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc tweaks and fixes to the interpreter #2125
Open
Jaklyy
wants to merge
121
commits into
melonDS-emu:master
Choose a base branch
from
Jaklyy:interpreter-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes gbarunner3
full list: strb, ldrb, strh, ldrd, strd, ldrh, ldrsb, ldrsh
kinda slow though?
i cannot comprehend what is happening currently
cmp and friends with bits 12-15 set to 1 borrow characteristics from their legacy 26 bit p variants thumb version does nothing of note
also my prior implementation made mrc w/ r15 raise an exception by accident oops!
pass bools as a single u8 instead and combine thumb and restore cpsr flags since they're mutually exclusive
fixes a bug with gbarunner3
prefetch aborts should be handled on executing an instruction by a flag set when the instruction is fetched
ty mgba discord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake of my prior interpreter pr to separate out the very complex and performance intensive pipelining timing rework from the miscellaneous bugfixes to get something more easily mergeable.
Fixes and features include:
(above fixes aid in getting gbarunner3 working!)