Fix build for clang #2088
Open
Fix build for clang #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed on Windows. I've updated the commit to restore the |
Remove declaring _POSIX_SOURCE manually. Let the compiler take care of this on its own, except on Windows where the compiler doesn't take care of this. Additionally, include a missing header file for the definition of struct sockaddr_in, which we need before we can allocate the struct. With these fixes, we can build with Clang 18.1.5, although there are many warnings.
|
Rebased on latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove declaring
_POSIX_SOURCEmanually. Let the compiler take care of this on its own where it can. Additionally, include a missing header file for the definition ofstruct sockaddr_in, which we need before we can allocate the struct. With these fixes, we can build with Clang 18.1.5, although there are many warnings.