Skip to content

Commit

Permalink
Item editor fixup (Astrabit-ST#86)
Browse files Browse the repository at this point in the history
* fix: fix item IDs being calculated incorrectly

* fix: access items directly instead of cloning

* fix: improve the layout of the item editor

* fix: make all the rows in the item editor the same height

* fix: prevent the "Change maximum..." button from wrapping

* fix: add spacing on either side of the separator

* fix: update the name of the item editor window properly

* chore: clippy

* fix: replace the `eprintln!` with a toast

* feat: add combo boxes for scope and occasion

* fix: enable text wrap for `EnumComboBox`

* feat: add the remaining combo boxes and numeric inputs

* feat: add stripes to item editor and combo box dropdowns

* fix: fix typo in toasts.rs

* fix: fix `ExactSizeIterator` implementation for `FileSystemTrieDirIter`

* feat: add element selection

* fix: use different UI IDs for each item ID

* fix: fix `IdVecSelection` creating duplicate entries in the vector

* feat: add state change selection

* fix: fix `IdVecSelection` deduplication for real this time

* fix: remove scrollbars from `IdVecSelection`

* fix: fix `IdVecPlusMinusSelection` minus shift selection

This makes it so that shift selection without the control key held
creates minuses if the pivot is a minus instead of always creating
pluses.

* feat: reset items when delete/backspace is pressed

* feat: add search box to `OptionalIdComboBox`

* feat: add search box to `id_vec` selection widgets

* fix: set a minimum width for the main item editor area

* chore: clippy

* fix: fix `id_vec` selection displaying incorrectly when searching

* fix: use `ui.make_persistent_id` for `OptionalIdComboBox` `state_id`
  • Loading branch information
white-axe authored Jan 9, 2024
1 parent e23f9b4 commit 4f08ed1
Show file tree
Hide file tree
Showing 9 changed files with 1,216 additions and 78 deletions.
10 changes: 10 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crates/components/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,5 @@ indextree = "4.6.0"
lexical-sort = "0.3.1"

fragile.workspace = true

fuzzy-matcher = "0.3.7"
Loading

0 comments on commit 4f08ed1

Please sign in to comment.