Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/dev' into terminal-rewrite
Browse files Browse the repository at this point in the history
  • Loading branch information
melody-rs committed Mar 20, 2024
2 parents 9852ca2 + c224ff6 commit 0725713
Show file tree
Hide file tree
Showing 10 changed files with 139 additions and 200 deletions.
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ person(s) who reviewed your changes. This will make sure it gets re-added to the

- [ ] Run `cargo fmt`.
- [ ] Run `cargo clippy`. If applicable, add:
- [ ] `--target wasm32-unknown-unknown`
- [ ] Run `cargo build --release`
- [ ] If applicable, run `trunk build --release`
- [ ] `--target wasm32-unknown-unknown -Z build-std=std,panic_abort`
- [ ] Run `cargo build --release`
- [ ] If applicable, run `trunk build --release`
174 changes: 50 additions & 124 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,6 @@ opt-level = 3
# https://bevy-cheatbook.github.io/pitfalls/performance.html#why-not-use---release

[patch.crates-io]
# We need this for rodio to work in WebAssembly until
# https://github.com/RustAudio/cpal/pull/774
# is merged.
cpal = { git = "https://github.com/DouglasDwyer/cpal.git", rev = "91aeb4d6b02c25791f636fdf92a73637597c077a" }

# flume's global spinlock uses `thread::sleep` which doesn't work in the main thread in WebAssembly.
# This is a patched version with `thread::sleep` removed in WebAssembly builds.
# See https://github.com/zesterer/flume/issues/137.
Expand Down
2 changes: 1 addition & 1 deletion crates/audio/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ thiserror.workspace = true
luminol-filesystem.workspace = true

[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
rodio = "0.17.1"
rodio = "0.17.3"

[target.'cfg(target_arch = "wasm32")'.dependencies]
rodio = { version = "0.17.1", features = ["wasm-bindgen"] }
Expand Down
Loading

0 comments on commit 0725713

Please sign in to comment.