Fix JS output in 'Working with JavaScript objects and values' page #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feihong
force-pushed
the
working-with-js-obj-val
branch
from
c273e71 to
486c3f9
Compare
feihong
force-pushed
the
working-with-js-obj-val
branch
from
486c3f9 to
98722f8
Compare
feihong
changed the title
…ects when in reasonml mode
feihong
commented
Jan 4, 2025
| @@ -202,7 +202,7 @@ manual](https://v2.ocaml.org/manual/objectexamples.html). | |||
| We have already explored one approach for creating JavaScript object literals by | |||
| using [`Js.t` values and the `mel.obj` extension](#using-js-t-objects). | |||
|
|
|||
| Melange additionally offers the `@mel.obj` attribute, which can be used in | |||
| Melange additionally offers the `mel.obj` attribute, which can be used in | |||
There was a problem hiding this comment.
Removed the @ from attribute names that was added in previous PR.
| position. Not having the last param `unit` would lead to a warning, which is | ||
| explained in detail [in the OCaml | ||
| documentation](https://ocaml.org/docs/labels#warning-this-optional-argument-cannot-be-erased). | ||
| > **Note**: in this particular case, a final param of type unit, `()` must be |
There was a problem hiding this comment.
@jchavarri I wonder if we can migrate to new syntax for custom containers in vitepress? They are more pleasant to edit, but they do have different styling than this old syntax.
| @@ -1076,20 +1075,20 @@ not prevent consumers of the external function from calling it using values that | |||
| are unsupported by the JavaScript function. Let’s see how we can use polymorphic | |||
| variants to avoid runtime errors. | |||
|
|
|||
| If the values are strings, we can use the `mel.string` attribute: | |||
| If the values are strings, we can directly use polymorphic variants: | |||
There was a problem hiding this comment.
I changed this because Melange compiler now generates warning if you try to use mel.string in this way
| used, and the `##` infix operator allows to read from the object properties: | ||
| the properties inside them. | ||
|
|
||
| - To create values, use the <span class="text-ocaml">`[%mel.obj]` extension |
There was a problem hiding this comment.
Added reasonml-specific text since formatting let john = [%mel.obj { name : "john", age : 99 }]; in Reason syntax will convert it to just let john = { "name": "john", "age": 99 }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some typos and mistakes on the 'Working with JavaScript objects and values' page, and in the process converted all the JS output from commonjs to es6 (since I used Melange Playground to generate the snippets and all JS output there is es6 now).