Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing web worker related API #18

Open
tonyfettes opened this issue Jun 16, 2024 · 6 comments · May be fixed by #19
Open

Missing web worker related API #18

tonyfettes opened this issue Jun 16, 2024 · 6 comments · May be fixed by #19

Comments

@tonyfettes
Copy link

Hi, I'm using melange for a academic project. I want to put all computation inside a worker so it doesn't froze the page. However, there is currently no support for web worker (yet?) in melange-webapi.

I have learned how to bind to JS using melange by developing the very same project, so I think I want to try to add these bindings myself. As per the contribution guidelines, I open a issue here to potentially save some work.

There is no discussion section in this repo so I might post some questions below as well to seek help & for record.
@davesnx
Copy link
Member

davesnx commented Jun 25, 2024

Totally @tonyfettes. Feel free to push a PR or even a draft and ping me.

This was referenced Jun 26, 2024
Open
Merged
@tonyfettes
Copy link
Author

tonyfettes commented Jun 26, 2024 •
edited
Loading

@davesnx I created a (actually two) draft PRs. Here are some questions I have in my mind after some initial attempts.

  1. Technically worker is not part of the DOM API. Although I put them in the DOM folder, I think I should move them out of the Dom/ folder. However, I see fetch API is in its own standalone package. Why some APIs are kept here while others are separated out (like fetch) as standalone packages. Should I make worker APIs a package?

  2. How can I test for the correctness of my binding? I browsed the tests/ directory, but since no typical OCaml test frameworks are used (like ounit, alcotest, and expect_test), how does the tests work?

  3. Do I really need to modify the compiler? I add some type definitions in the jscomp/others/dom.ml and they're purely abstract type definitions. My hypothesis is they can also work if I move all these type definitions in this repo as a file, but I'm really not sure.

Thank you in advance.

@davesnx
Copy link
Member

davesnx commented Jun 26, 2024

Nice,

  1. Historical reasons I would say. Since bindings have some subjective design, sometimes authors have diverged implementations. In case of fetch, could be part of this repo IMO.

  2. Testing the browser isn't as easy as running alcotest or ounit. You would need to either run a browser (via puppetter) or a JavaScript test suit (probably jest with a bit of config to support webworkers) or manually with a demo.

  3. Some types are abstract and inside the compiler to allow any library to extend bindings/libraries with those types. Either way, if you think the types are correct, I would push them to melange itself.

@anmonteiro
Copy link
Member

In case of fetch, could be part of this repo IMO.

I disagree. fetch is way more useful by itself than this repo (which I've never used, though I use melange-fetch everywhere)

@davesnx
Copy link
Member

davesnx commented Jul 2, 2024

Maybe you didn't need webapi?

At least I would say re_exporting fetch in webapi make sense

@anmonteiro
Copy link
Member

Maybe you didn't need webapi?

Oh I did, but this library is a bit of an overkill if you just need a few externals that are easy to write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add worker api tonyfettes/melange-webapi
3 participants
@anmonteiro @davesnx @tonyfettes